Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 0 is not a valid isGlobal value, use 'null' instead. #16820

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Sep 25, 2024

What does this PR do?

Fixes

Foreign key constraint failed on the field: `BookingReference_credentialId_fkey (index)`

When updating a booking to the Daily provider on the booking listing as the credentialId is returned in the locationOptions list.

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 1:04pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 1:04pm

@graphite-app graphite-app bot requested a review from a team September 25, 2024 18:07
@keithwillcode keithwillcode added core area: core, team members only foundation labels Sep 25, 2024
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Sep 25, 2024
joeauyeung
joeauyeung previously approved these changes Sep 25, 2024
Copy link

graphite-app bot commented Sep 25, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (09/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/25/24)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode
Copy link
Contributor

Wow

@emrysal
Copy link
Contributor Author

emrysal commented Sep 25, 2024

Yes, this'll need some more work @keithwillcode to deal with "Fake" apps like these (that are always installed). We 0'ed these values at one point to keep it consistent with the interface but honestly we should do a GlobalApp and InstallableApp type differentiator.

@emrysal emrysal marked this pull request as draft September 25, 2024 18:32
auto-merge was automatically disabled September 25, 2024 18:32

Pull request was converted to draft

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only foundation ready-for-e2e Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants