feat: adding posthog libs for node + js #16862

abhi-slash-git · 2024-09-27T15:28:51Z

What does this PR do?

Adds posthog node + js libs for event tracking.

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

vercel · 2024-09-27T15:28:56Z

@abhi-slash-git is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2024-09-27T15:28:58Z

All committers have signed the CLA.

graphite-app · 2024-09-27T15:30:10Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/27/24)

1 label was added to this PR based on Keith Williams's automation.

abhi-slash-git · 2024-09-27T15:31:26Z

@sean-brydon PR created, would like your help with the frontend setup. Thank you

sean-brydon · 2024-09-30T16:37:23Z

@sean-brydon PR created, would like your help with the frontend setup. Thank you

Posthog is now initializing on the frontend and saving page views.

We should think when we want to call the identify function on the user - in shell was re-rendering too much. Maybe we do this upon login?

abhi-slash-git · 2024-10-01T13:06:59Z

@sean-brydon Yep you are right, we can do this on login. We also have to remember to do call reset() on logout as well.

abhi-slash-git · 2024-10-07T14:18:16Z

packages/features/ee/event-tracking/lib/posthog/userPostHog.tsx

+      organization: data?.organization?.slug,
+      sum_of_event_types: data?.sumOfEventTypes,
+      sum_of_team_event_types: data?.sumOfTeamEventTypes,
+      is_premium: data?.isPremium,


@sean-brydon check which properties to remove

packages/features/auth/lib/next-auth-options.ts

abhi-slash-git · 2024-10-11T16:53:55Z

@sean-brydon bump for visibilty

github-actions · 2024-10-26T00:20:48Z

This PR is being marked as stale due to inactivity.

github-actions · 2024-11-01T11:52:39Z

E2E results are ready!

Workflow #36818.1 latest results

vercel · 2024-11-01T12:57:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Nov 2, 2024 2:44am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Nov 2, 2024 2:44am

sean-brydon

LGTM - will see if someone else can have some eyes as i did a bit of work on this also

baileypumfleet

Code looks good to me

Thank you for your help on this :)

baileypumfleet · 2024-11-02T02:36:15Z

packages/features/ee/event-tracking/lib/posthog/provider.tsx

+  useEffect(() => {
+    if (!process.env.NEXT_PUBLIC_POSTHOG_KEY) return;
+    posthog.init(process.env.NEXT_PUBLIC_POSTHOG_KEY, {
+      api_host: process.env.NEXT_PUBLIC_POSTHOG_HOST || "https://us.i.posthog.com",


Even though we use the EU PostHog region, we can keep the US one as the fallback

baileypumfleet · 2024-11-02T12:32:03Z

@abhi-slash-git could you sign the CLA real quick? You should see it as the second comment on this PR

neuhaus · 2024-11-06T15:56:57Z

Building the docker container with this change applied fails for me as follows:

   Linting and checking validity of types ...
Failed to compile.

../../packages/features/ee/event-tracking/lib/posthog/web/PostHogPageView.tsx:15:11
Type error: 'searchParams' is possibly 'null'.

  13 |     if (pathname && posthog) {
  14 |       let url = window.origin + pathname;
> 15 |       if (searchParams.toString()) {
     |           ^
  16 |         url = `${url}?${searchParams.toString()}`;
  17 |       }
  18 |       posthog.capture("$pageview", {
The command '/bin/sh -c yarn --cwd apps/web workspace @calcom/web run build' returned a non-zero code: 1

neuhaus · 2024-11-06T15:59:20Z

i guess changing the line to
if (searchParams?.toString()) {
will fix the issue?

neuhaus · 2024-11-07T10:48:02Z

@abhi-slash-git i don't understand why you didn't have this issue during building

abhi-slash-git · 2024-11-07T12:19:15Z

@sean-brydon might know, I believe he added this change

zomars · 2024-11-12T18:07:23Z

@neuhaus @abhi-slash-git @sean-brydon this is now causing issues locally. I'm getting the same errors when building locally.

adding posthog libs for node + js

6b497f4

graphite-app bot added the community Created by Linear-GitHub Sync label Sep 27, 2024

graphite-app bot requested review from a team September 27, 2024 15:28

github-actions bot added the ❗️ .env changes contains changes to env variables label Sep 27, 2024

dosubot bot added insights area: insights, analytics ✨ feature New feature or request labels Sep 27, 2024

abhi-slash-git marked this pull request as draft September 27, 2024 15:30

updating lock

b09e41b

sean-brydon mentioned this pull request Sep 30, 2024

[CAL-3573] analytics apps: add "Confirm" as a trigger event #14789

Open

move to init posthog client - pageview component

9c2aa54

adding identify in shell

610e54d

abhi-slash-git commented Oct 7, 2024

View reviewed changes

packages/features/auth/lib/next-auth-options.ts Show resolved Hide resolved

removing test event captures

a58a7bb

abhi-slash-git marked this pull request as ready for review October 7, 2024 14:36

fixing merge conflicts

9a240a5

github-actions bot added the Stale label Oct 26, 2024

sean-brydon added 2 commits November 1, 2024 08:57

Merge branch 'main' into abhi/adding-posthog-event-tracking

343f2c4

add signout tracking to dropdown as it was missed in merge

002a860

hariombalhara added ready-for-e2e and removed Stale labels Nov 1, 2024

keithwillcode added ready-for-e2e and removed ready-for-e2e labels Nov 1, 2024

vercel bot deployed to Preview – api November 1, 2024 13:05 View deployment

sean-brydon reviewed Nov 1, 2024

View reviewed changes

baileypumfleet approved these changes Nov 2, 2024

View reviewed changes

Merge branch 'main' into abhi/adding-posthog-event-tracking

82774e7

baileypumfleet enabled auto-merge (squash) November 2, 2024 02:43

vercel bot deployed to Preview – api November 2, 2024 02:52 View deployment

baileypumfleet added ❗️ .env changes contains changes to env variables and removed ❗️ .env changes contains changes to env variables labels Nov 2, 2024

keithwillcode added this to the v4.7 milestone Nov 3, 2024

baileypumfleet disabled auto-merge November 4, 2024 16:24

Merge branch 'main' into abhi/adding-posthog-event-tracking

0e74694

baileypumfleet merged commit ddfbe25 into calcom:main Nov 4, 2024
32 of 36 checks passed

zomars mentioned this pull request Nov 12, 2024

[CAL-4705] Type error: 'searchParams' is possibly 'null' #17602

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding posthog libs for node + js #16862

feat: adding posthog libs for node + js #16862

abhi-slash-git commented Sep 27, 2024

vercel bot commented Sep 27, 2024

CLAassistant commented Sep 27, 2024 •

edited

Loading

graphite-app bot commented Sep 27, 2024

abhi-slash-git commented Sep 27, 2024

sean-brydon commented Sep 30, 2024

abhi-slash-git commented Oct 1, 2024

abhi-slash-git Oct 7, 2024

abhi-slash-git commented Oct 11, 2024

github-actions bot commented Oct 26, 2024

github-actions bot commented Nov 1, 2024 •

edited

Loading

vercel bot commented Nov 1, 2024 •

edited

Loading

sean-brydon left a comment

baileypumfleet left a comment

baileypumfleet Nov 2, 2024

baileypumfleet commented Nov 2, 2024

neuhaus commented Nov 6, 2024

neuhaus commented Nov 6, 2024

neuhaus commented Nov 7, 2024

abhi-slash-git commented Nov 7, 2024

zomars commented Nov 12, 2024

feat: adding posthog libs for node + js #16862

feat: adding posthog libs for node + js #16862

Conversation

abhi-slash-git commented Sep 27, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

vercel bot commented Sep 27, 2024

CLAassistant commented Sep 27, 2024 • edited Loading

graphite-app bot commented Sep 27, 2024

Graphite Automations

abhi-slash-git commented Sep 27, 2024

sean-brydon commented Sep 30, 2024

abhi-slash-git commented Oct 1, 2024

abhi-slash-git Oct 7, 2024

Choose a reason for hiding this comment

abhi-slash-git commented Oct 11, 2024

github-actions bot commented Oct 26, 2024

github-actions bot commented Nov 1, 2024 • edited Loading

E2E results are ready!

vercel bot commented Nov 1, 2024 • edited Loading

sean-brydon left a comment

Choose a reason for hiding this comment

baileypumfleet left a comment

Choose a reason for hiding this comment

baileypumfleet Nov 2, 2024

Choose a reason for hiding this comment

baileypumfleet commented Nov 2, 2024

neuhaus commented Nov 6, 2024

neuhaus commented Nov 6, 2024

neuhaus commented Nov 7, 2024

abhi-slash-git commented Nov 7, 2024

zomars commented Nov 12, 2024

CLAassistant commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024 •

edited

Loading

vercel bot commented Nov 1, 2024 •

edited

Loading