Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Enhance SalesforceCRMService with improved contact querying… #18292

Closed
wants to merge 1 commit into from
Closed

refactor: Enhance SalesforceCRMService with improved contact querying… #18292

wants to merge 1 commit into from
+213 −159

Conversation

Udit-takkar
Copy link
Contributor

… and owner information handling

  • Removed deprecated ContactSearchResult type.
  • Introduced new interfaces for better type safety: GetContactsParams, ContactQueryResult, BuildContactQueryParams, ContactWithOwner, and BasicContactInfo.
  • Refactored getContacts method to utilize a new buildContactQuery method for constructing SOQL queries.
  • Improved handling of account and contact records, including fallback logic for owner information.
  • Added utility methods for filtering valid owner queries and mapping records with owner info.
  • Enhanced logging for better traceability of contact retrieval processes.

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@Udit-takkar
refactor: Enhance SalesforceCRMService with improved contact querying…
55b7b4d 
… and owner information handling

- Removed deprecated ContactSearchResult type.
- Introduced new interfaces for better type safety: GetContactsParams, ContactQueryResult, BuildContactQueryParams, ContactWithOwner, and BasicContactInfo.
- Refactored getContacts method to utilize a new buildContactQuery method for constructing SOQL queries.
- Improved handling of account and contact records, including fallback logic for owner information.
- Added utility methods for filtering valid owner queries and mapping records with owner info.
- Enhanced logging for better traceability of contact retrieval processes.
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Dec 20, 2024 7:48am
calcom-web-canary ⬜️ Ignored (Inspect) Dec 20, 2024 7:48am

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Dec 20, 2024
@Udit-takkar
Copy link
Contributor Author

closing because it would cause conflicts with #18289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Udit-takkar @keithwillcode