Unicode characters support in regex #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliotwrobson
requested changes
Jul 27, 2024
There was a problem hiding this comment.
@kunchtler thanks for this! One request to make this test a little more robust, but overall I think the change looks good.
| def test_validate_unicode_characters(self) -> None: | ||
| """Should pass validation for regular expressions with unicode characters.""" | ||
| re.validate("(µ|🤖ù)*") | ||
|
|
There was a problem hiding this comment.
Should add a test that an nfa converted from this regex has the expected set of input symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #232.
Changed the order in which the tokens are registered in the regex lexer to process the rule about recognizing letters last, and changed that rule to account for all non-blank characters (as specified per python's
relibrary with\S).Added a test to check for the support of non-ascii characters.
This is my very first pull request ever so feel free to guide me.