Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determinized regex ordering #235

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Determinized regex ordering #235

wants to merge 2 commits into from

Conversation

eliotwrobson
Copy link
Collaborator

Resolves #231 by determinizing the order that nodes get removed in the GNFA algorithm, and adds a corresponding test.

@eliotwrobson eliotwrobson added the correct-behavior The reported issue is not actually a bug, but represents the correct and intended behavior label Jul 27, 2024
@eliotwrobson eliotwrobson self-assigned this Jul 27, 2024
@coveralls
Copy link

coveralls commented Jul 27, 2024 •
edited
Loading

Coverage Status

coverage: 99.613%. remained the same
when pulling f31d84e on eliotwrobson:to_regex_ordering
into 9ab1a1c on caleb531:develop.

@eliotwrobson eliotwrobson linked an issue Jul 27, 2024 that may be closed by this pull request
to_regex method returns different results for the same input #231
Open
caleb531
caleb531 reviewed Jul 27, 2024
View reviewed changes
tests/test_gnfa.py Outdated Show resolved Hide resolved
@eliotwrobson eliotwrobson marked this pull request as draft July 27, 2024 21:47
caleb531
caleb531 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Owner

@caleb531 caleb531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliotwrobson Left a comment noting one one trivial observation, but otherwise looks good to me!

@caleb531
Copy link
Owner

@eliotwrobson Actually, I see that tests are failing on 3.8 and 3.12. Will need those tests to pass before merging.

@eliotwrobson @caleb531
Update tests/test_gnfa.py
f31d84e 
Co-authored-by: Caleb Evans <caleb@calebevans.me>
@eliotwrobson
Copy link
Collaborator Author

@caleb531 yes, it looks like we're still getting some non-deterministic behavior still. I'll have to take another look later, I'm not quite sure where that behavior might be creeping in. Feel free to take a look if you like in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb531 caleb531 caleb531 approved these changes

Assignees

@eliotwrobson eliotwrobson

Labels
correct-behavior The reported issue is not actually a bug, but represents the correct and intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_regex method returns different results for the same input
3 participants
@eliotwrobson @coveralls @caleb531