Refactor GoVPP usage and generation #22
Conversation
pkg/gen_vpplink.go
Outdated
| } | ||
|
|
||
| func createGenerateLog(apiDir string, fname string) { | ||
| /*func createGenerateLog(apiDir string, fname string) { |
There was a problem hiding this comment.
It's debatable whether we want to keep this or not. I'd arguee it's always good to have a trail of what generated the bindings. The file headers can serve for this as well, the good thing about having a dedicated file though is that it can be parsed/copied to a container where the file headers are more for human consumption.
pkg/gen_vpplink.go
Outdated
| @@ -57,7 +51,9 @@ func init() { | |||
|
|
|||
| } | |||
|
|
|||
| func GenerateFile(gen *binapigen.Generator) { | |||
| func GenerateFile(gen *binapigen.Generator, file *binapigen.File) *binapigen.GenFile { | |||
There was a problem hiding this comment.
This is more of a Govpp comment, but anyway, the issue with this is we are going to be called once for every file even though the generation we are doing does not depend on the files being passed.
That's why I originally went with changing the signature for GenerateFile in https://github.com/FDio/govpp/pull/68/files#diff-4d2bacb13fc145b9d2f0e4f6a3771998ef6f3ff8d78dde2682c577febfa0f16eR30
|
lgtm, thanks @ondrej-fabry ! |
This PR contains:
CC @sknat