Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider vintage availability in cost calculations #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brynpickering
Copy link
Member

The current implementation is summing flow_cap_new across vintagesteps no matter what investment period you're in. So, in 2030 it is the sum of new capacity costs in 2020, 2030, 2040, and 2050! It should just be 2020 and 2030, or not even 2020 if the technology lifetime < 10 years.

Copy link
Collaborator

@irm-codebase irm-codebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big oversight! Hopefully the results make more sense now (I think this will smooth the investments, definitely).

I just have a couple of questions regarding some unclear names, and where they are sourced from.
I'll approve after that 👍

src/calliope_pathways/math/pathways.yaml Show resolved Hide resolved
equations:
- expression: >
$annualisation_weight * (
$depreciation_rate * (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, could you explain where annualisation_weight and depreciation_rate are set?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the expression, it seems we are close to TEMOA's approach, which I think is good...

But honestly it's a tad hard to be sure on my part...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irm-codebase
Copy link
Collaborator

I thought I had approved this a while ago, turns out I did not!
Anyhow, feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants