-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and remove scenarios.yaml #241
Conversation
@brynpickering is this ready to be reviewed again? |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it now!
One small thing needs to be fixed: all code boxes (yaml and python) in the overrides section of customisation.md are broken (have a look at the readthedocs preview). Not sure what's going on but it's basically unreadable right now.
It works for me too. Also, I figured just now, that these code blocks are broken in other parts of the documentation on readthedocs, too. That's weird. Is it possible that this is a glitch in the built? |
I checked the supposed dead markdown link (https://open-power-system-data.org/) and it isn't dead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for following up on this, @brynpickering . It all looks good to me now, apart from the erratic behaviour of the Markdown link check. We need to investigate what's going on or otherwise remove it. It's suspicious that it's consistently open-power-system-data that's failing.
Fixes #230 & #236. Reverts #209.
Since we are now modular, it's impossible to have any one file that links to the contents of multiple other files (as
scenarios.yaml
was doing in grouping overrides). So, we have to remove this file and instead document how one would create their own scenarios by grouping overrides.Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.