Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature update workflow infra #264

Conversation

timtroendle
Copy link
Member

@timtroendle timtroendle commented May 23, 2023

Fixes #253

Fixes #255

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

@timtroendle
Copy link
Member Author

This is fully implemented but blocked by #263.

@timtroendle timtroendle force-pushed the feature-update-workflow-infra branch from e07f6cd to 1b33760 Compare June 1, 2023 09:16
@timtroendle timtroendle marked this pull request as ready for review June 1, 2023 09:27
Copy link
Member

@brynpickering brynpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I'm just running the minimal workflow locally, to double check it ;)

docs env file needs fixing, see my separate comment on that.

envs/docs.yaml Show resolved Hide resolved
@timtroendle
Copy link
Member Author

I have no clue why the environment cannot be resolved on readthedocs. It works just fine on my machine.

It maybe a Linux problem, but I cannot test that right now as Euler is down for maintenance. Then again, the missing dependency toposort>=1.10 is a noarch package, so it does not really make sense to me.

@brynpickering
Copy link
Member

You can always trust mamba to solve all your issues :)

@brynpickering brynpickering merged commit e0fc14d into calliope-project:develop Jun 7, 2023
jnnr pushed a commit to jnnr/euro-calliope that referenced this pull request Aug 27, 2024
…te-workflow-infra

Update workflow infrastructure
jnnr pushed a commit to jnnr/euro-calliope that referenced this pull request Aug 27, 2024
…te-workflow-infra

Update workflow infrastructure
jnnr pushed a commit to jnnr/euro-calliope that referenced this pull request Aug 27, 2024
…te-workflow-infra

Update workflow infrastructure
jnnr pushed a commit to jnnr/euro-calliope that referenced this pull request Sep 3, 2024
…te-workflow-infra

Update workflow infrastructure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the Snakemake call Configuration changes should trigger rerun of the workflow
2 participants