Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemeted function to disaggregate into regional timeseries. #277

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Implemeted function to disaggregate into regional timeseries. #277

merged 4 commits into from
Mar 12, 2024

Conversation

jonathan-peel
Copy link
Contributor

@jonathan-peel jonathan-peel commented Mar 11, 2024 •
edited by timtroendle
Loading

Changed .smk file accordingly.

Fixes #270 .

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

adrienmellot
adrienmellot reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@adrienmellot adrienmellot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modifications seem good. From the Checklist, did you check that the minimal workflow tests pass? Other items of the checklist are covered.

timtroendle
timtroendle approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@timtroendle timtroendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one important documentation comment. Apart from that, this looks good to me.

scripts/transport/aggregate_timeseries.py Show resolved Hide resolved
scripts/transport/aggregate_timeseries.py Outdated Show resolved Hide resolved
@timtroendle
Copy link
Member

The minimal workflow works runs smoothly.

@timtroendle timtroendle merged commit 0ffeae5 into calliope-project:develop Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienmellot adrienmellot adrienmellot left review comments

@timtroendle timtroendle timtroendle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fully-electrified road transport
3 participants
@jonathan-peel @timtroendle @adrienmellot