Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule that generates the DAG #281

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

timtroendle
Copy link
Member

@timtroendle timtroendle commented Mar 13, 2024

Fixes #208

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

Copy link
Contributor

@adrienmellot adrienmellot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the DAG and all seems good. Wondering if we should save as a .png instead of a .pdf ?

@timtroendle
Copy link
Member Author

We decided to stay with PDF as it's zoomable, being a vector graphic.

@timtroendle timtroendle merged commit 1685e78 into calliope-project:develop Mar 14, 2024
3 checks passed
@timtroendle timtroendle deleted the feature-dag-rule branch March 14, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a rule that generates the dag visualisation
2 participants