Implement realistic timeseries for transport demand #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtroendle
approved these changes
Mar 15, 2024
| # Process the road transport distance timeseries | ||
| create_timeseries(type_name, power_scaling_factor, conversion_factor, first_year, | ||
| final_year, series, path_to_output, historic=historic) | ||
| # TODO check if path_to_timeseries data is charging demand or transport demand |
There was a problem hiding this comment.
We should have an issue for this.
|
|
||
| if vehicle_type in ["passenger-cars","motorcycles","light-duty-vehicles"]: | ||
| df_timeseries = ( |
There was a problem hiding this comment.
Here, a comment just above would be helpful. A comment explaining the if /else. Maybe:
# Use RAMP time series profiles for small and light vehicles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.