-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more recent curl version to fix hydro basins download #304
Use more recent curl version to fix hydro basins download #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Could you also update the CHANGELOG.md? This seems to fit into the ### Fixed (workflow)
section.
Thanks for your review, @timtroendle! The minimal workflow is still running. I'll check the box if it finishes successfully. |
Unfortunately, when running the minimal workflow I get a new error:
and
|
Oh no, how annoying. The whole point of providing curl through Snakemake was to INCREASE portability, not DECREASE it. See #64. Seems we failed. I finally managed to reproduce the original problem with version 7.76.0. It indeed does fail on our Linux system, too! Seems we haven't run the download for quite a while. Unfortunately, I again fail to reproduce the problem with version 8.6.0. All downloads (basins, load, capacity-factors) work just fine using version Also, I figured why you don't see error messages: curl requires the Could you rerun with the |
They have also released version 8.7.1 just a few days ago. In the absence of other solutions, you could also try updating again. |
I have just re-run again after wiping all build and data files to ensure everything is downloaded, and for me, it works with curl I do have another issue that I haven't raised so far but that I always had to fix to get the shell environment working to begin with (on linux only, #321). |
I ran this again on my own computer and esm1. On my own computer, at first run I encountered the above errors again when downloading data/automatic/capacityfactors/wind-onshore-timeseries.nc and data/automatic/raw-load-data.csv. After starting the workflow again it succeeded however without me conciously changing anything. So I'd suggest we count this as resolved and open a new issue if problems persist. |
Fixes #267.
Checklist