Feature uncontrolled vs controlled charging #338

adrienmellot · 2024-04-10T10:00:47Z

This PR does not fix any issue but is a step towards fixing #274 , #273 , #81 .

This separates fully electrified road transport demand into a controlled part (for now, as an annual demand to be met without any constraints), and an uncontrolled part (as a fixed timeseries profile). This share is a parameter to be decided by in the config file.

To note:

There is an inconsistency with the override "keep-historic-electricity-demand-from-road-transport" because we've assumed historical electrified transport to be uncontrolled. If you activate the override, you are still counting this electricity demand as uncontrolled.

Co-authored by: Francesco Sanvito sanvitofrancesco@gmail.com

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

for more information, see https://pre-commit.ci

…com/adrienmellot/euro-calliope into feature-uncontrolled-charging-share

brynpickering

A few comments to address

brynpickering · 2024-04-10T10:34:51Z

Snakefile

@@ -98,7 +99,7 @@ rule all_tests:


 rule dummy_tech_locations_template:  # needed to provide `techs_and_locations_template` with a locational CSV linked to each technology that has no location-specific data to define.
-    message: "Create empty {wildcards.resolution} location-specific data file for the {wildcards.tech_group} tech `{wildcards.tech}`."
+    message: "Create empty {wildcards.resolution} location-specific data file for the {wildcards.tech_group} tech `{wildcards.tech}`."  # Not used only if ruleorder is updated at top of file


Maybe update to: Update ruleorder at the top of the file if you instead want the techs_and_locations_template rule to be used to generate a file

brynpickering · 2024-04-10T10:36:37Z

config/default.yaml

@@ -162,6 +162,7 @@ parameters:
            coaches-and-buses: Motor coaches, buses and trolley buses
            passenger-cars: Passenger cars
            motorcycles: Powered 2-wheelers
+        uncontrolled-charging-share: 0.5


Suggested change

uncontrolled-charging-share: 0.5

uncontrolled-ev-charging-share: 0.5

brynpickering · 2024-04-10T10:37:01Z

rules/transport.smk

@@ -1,7 +1,7 @@
 """Rules to process transport sector data."""


-rule download_transport_timeseries:
+rule download_transport_timeseries: # TODO have correct timeseries data once RAMP has generated the new charging profile and it's been put on Zenodo


Add the TODO on the line below. Makes it easier to read

brynpickering · 2024-04-10T10:40:24Z

rules/transport.smk

    script: "../scripts/transport/road_transport_timeseries.py"


-use rule create_road_transport_timeseries as create_road_transport_timeseries_historic_electrification with:
-    message: "Create timeseries for historic electrified road transport demand"
+use rule create_uncontrolled_road_transport_timeseries as create_unctronolled_road_transport_timeseries_historic_electrification with:


brynpickering · 2024-04-10T10:42:43Z

rules/transport.smk

-            "build/data/transport/timeseries/timeseries-coaches-and-buses.csv",
-            "build/data/transport/timeseries/timeseries-passenger-cars.csv",
-            "build/data/transport/timeseries/timeseries-motorcycles.csv"),
+            "build/data/transport/timeseries/timeseries-uncontrolled-light-duty-vehicles.csv",


Turn this into a for loop that uses the keys from the config to decide what needs to be built.

brynpickering · 2024-04-10T10:44:36Z

scripts/transport/annual_transport_demand.py

+        .sub(total_historically_electrified_distance.rename("value"), fill_value=0)
+        .to_csv(snakemake.output.road_distance_uncontrolled)
+    )
+    road_distance_historically_electrified = (  # ASSUME historically electrified road consumption is all uncontrolled


put comment in its own line (above)

brynpickering · 2024-04-10T10:46:27Z

scripts/transport/road_transport_controlled_charging.py

I haven't looked, but how close is this to a copy-paste of the uncontrolled python file? If it is very similar, we should consider using the two files with a controlled/uncontrolled flag that decides on the functions to use etc.

It's fairly different, because the uncontrolled scripts generate timeseries per vehicle type which are then aggregated and rescaled per resolution. This last step is similar but still different because contains different data structures. The controlled script is actually closer to the rescale.py in the heat sector.

for more information, see https://pre-commit.ci

brynpickering

Need to also update docs customisation.md note "demand/electrified-transport.yaml"

brynpickering · 2024-04-10T14:40:28Z

templates/models/techs/demand/electrified-transport.yaml

 locations:
    {% for id, location in locations.iterrows() %}
-    {{ id }}.techs.demand_road_transport_electrified:
-    {{ id }}.techs.demand_road_transport_historic_electrified:
+    {{ id }}.techs.demand_road_transport_electrified_uncontrolled:


Needs controlled tech here too. I'd maybe update to:

{{ id }}.techs: demand_road_transport_electrified_uncontrolled: demand_road_transport_historic_electrified_uncontrolled: demand_road_transport_electrified_controlled:

brynpickering · 2024-04-10T14:40:41Z

templates/models/techs/demand/electrified-transport.yaml

            parent: supply
            carrier: electricity
        constraints:
-            resource: file=demand/road-transport-historic-electrification.csv
+            resource: file=demand/uncontrolled-road-transport-historic-electrification.csv
            resource_min_use: 1


should this be "force_resource"?

I've updated it, indeed I think it makes more sense

for more information, see https://pre-commit.ci

…com/adrienmellot/euro-calliope into feature-uncontrolled-charging-share

…ontrolled-charging-share Feature uncontrolled vs controlled charging Co-authored by: Francesco Sanvito sanvitofrancesco@gmail.com

adrienmellot and others added 7 commits April 9, 2024 16:58

Add uncontrolled charging share

73b1ee3

Convert road distance to energy and scale per resolution

26d8718

Edit snakefile template and fix naming

92f36d7

Add annual controlled demand to yaml model files

85fdf51

[pre-commit.ci] auto fixes from pre-commit.com hooks

398520a

for more information, see https://pre-commit.ci

Update CHANGELOG.md

a40424f

Merge branch 'feature-uncontrolled-charging-share' of https://github.…

bfc041e

…com/adrienmellot/euro-calliope into feature-uncontrolled-charging-share

brynpickering reviewed Apr 10, 2024

View reviewed changes

adrienmellot and others added 2 commits April 10, 2024 14:33

Adress comments

ae2dc9b

[pre-commit.ci] auto fixes from pre-commit.com hooks

cc30987

for more information, see https://pre-commit.ci

brynpickering requested changes Apr 10, 2024

View reviewed changes

adrienmellot and others added 5 commits April 10, 2024 22:55

customisation.md and electrified-transport.yaml update

145c2a8

[pre-commit.ci] auto fixes from pre-commit.com hooks

58175ea

for more information, see https://pre-commit.ci

Update customisation.md

3c84405

Merge branch 'feature-uncontrolled-charging-share' of https://github.…

30df69a

…com/adrienmellot/euro-calliope into feature-uncontrolled-charging-share

Update customisation.md

5569fad

adrienmellot requested a review from brynpickering April 10, 2024 21:11

Minor fix to YAML template.

60a3e42

brynpickering approved these changes Apr 11, 2024

View reviewed changes

brynpickering merged commit 9a4de45 into calliope-project:develop Apr 11, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature uncontrolled vs controlled charging #338

Feature uncontrolled vs controlled charging #338

adrienmellot commented Apr 10, 2024 •

edited by brynpickering

Loading

brynpickering left a comment

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

adrienmellot Apr 10, 2024

brynpickering left a comment

brynpickering Apr 10, 2024

brynpickering Apr 10, 2024

adrienmellot Apr 10, 2024

	uncontrolled-charging-share: 0.5
	uncontrolled-ev-charging-share: 0.5

Feature uncontrolled vs controlled charging #338

Feature uncontrolled vs controlled charging #338

Conversation

adrienmellot commented Apr 10, 2024 • edited by brynpickering Loading

Checklist

brynpickering left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brynpickering left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrienmellot commented Apr 10, 2024 •

edited by brynpickering

Loading