-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uncontrolled charging RAMP profile #358
Fix uncontrolled charging RAMP profile #358
Conversation
…llot adrien.mellot@gmail.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and small, very good. If we have improved input data from RAMP now (e.g. more countries), it would be good to have new demand, plugin, and battery consumption profiles all in the same zenodo record. Do you have the other two profiles from the run you did?
Not really. The plug-in profiles are custom outputs, but I can easily regenerate all the three timeseries.. |
config/schema.yaml
Outdated
@@ -107,6 +107,10 @@ properties: | |||
type: string | |||
pattern: ^(https?|http?):\/\/.+ | |||
description: Web address of electric vehicle data. | |||
uncontrolled-ev-data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data
-> profiles
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just one last thing and then you can merge this in: update the changelog!
@FraSanvit if you could re-generate all the profiles we need for euro-calliope with the latest RAMP (incl. the new countries) that would be great. Not for this PR, but at some point. |
I've looked at the changelog and I am not sure we can really update it with this PR because we're fixing something that is 'added' to v1.2.0. What do you think? |
You could simply add this PR number to that existing entry. |
I've updated CHANGELOG accordingly. |
…port-profiles Fix uncontrolled charging RAMP profile
…port-profiles Fix uncontrolled charging RAMP profile
…port-profiles Fix uncontrolled charging RAMP profile
Fixes #287.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.