Update default profile to be a workflow-profile #361
Conversation
Default profile (in `profiles/default`) is now the default workflow profile. Snakemake activates it automatically using the name. This allows the user to inject other profile parameters using the `--profile` cli option. This also allows us to provide the conda configuration as an addition to, rather than a replacement of, the default profile. Fixes calliope-project#268
profiles/conda/config.yaml
Outdated
There was a problem hiding this comment.
As of v23.10.0, conda uses libmamba as its solver by default. So the two should be equally fast. Do we still need two separate profiles? Furthermore, I think as long as conda is installed as well as mamba, conda is used anyway, irrespective of whether you used mamba to install the euro-calliope environment -- unless you run snakemake with --conda-frontend mamba.
There was a problem hiding this comment.
Can we make the question whether we want to drop mamba a separate question? Right now, mamba is the default and whenever you want to run the workflow without, you have to use --profile="profiles/conda" or --conda-frontend conda which is essentially the same.
There was a problem hiding this comment.
Yes, agreed, that question is beyond the scope of this PR
|
Am I right in saying that it would now not be necessary to include |
|
No, it's still necessary. This pull request isn't changing any behaviour, but it adds the possibility to inject your own profile through We could get rid of this by dropping mamba support and running conda by default. |
|
Yes, that makes sense. Done. |
Default profile (in
profiles/default) is now the default workflow profile. Snakemake activates it automatically using the name. This allows the user to inject other profile parameters using the--profilecli option. This also allows us to provide the conda configuration as an addition to, rather than a replacement of, the default profile.Fixes #268
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.