-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default profile to be a workflow-profile #361
Update default profile to be a workflow-profile #361
Conversation
Default profile (in `profiles/default`) is now the default workflow profile. Snakemake activates it automatically using the name. This allows the user to inject other profile parameters using the `--profile` cli option. This also allows us to provide the conda configuration as an addition to, rather than a replacement of, the default profile. Fixes calliope-project#268
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs actually don't mention that there is a default workflow profile. This should probably be added, e.g. under the "Build" heading in build.md
. Particularly mentioning that it sets cores
to 2
.
profiles/conda/config.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of v23.10.0, conda uses libmamba as its solver by default. So the two should be equally fast. Do we still need two separate profiles? Furthermore, I think as long as conda is installed as well as mamba, conda is used anyway, irrespective of whether you used mamba to install the euro-calliope
environment -- unless you run snakemake with --conda-frontend mamba
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the question whether we want to drop mamba
a separate question? Right now, mamba
is the default and whenever you want to run the workflow without, you have to use --profile="profiles/conda"
or --conda-frontend conda
which is essentially the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed, that question is beyond the scope of this PR
Am I right in saying that it would now not be necessary to include |
No, it's still necessary. This pull request isn't changing any behaviour, but it adds the possibility to inject your own profile through We could get rid of this by dropping mamba support and running conda by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should euler/config.yaml
also be updated? It has conda-prefix
and software-deployment-method
which are now duplicated in the default profile.
Yes, that makes sense. Done. |
Default profile (in
profiles/default
) is now the default workflow profile. Snakemake activates it automatically using the name. This allows the user to inject other profile parameters using the--profile
cli option. This also allows us to provide the conda configuration as an addition to, rather than a replacement of, the default profile.Fixes #268
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.