-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ehighways resolution shape generation #370
Conversation
for more information, see https://pre-commit.ci
…on files and schemas.
Now need to implement the actual function properly.
Debug configuration set up also.
…nathan-peel/euro-calliope into feature-ehighways-resolution-unts-318
for more information, see https://pre-commit.ci
References to nuts-year "variable" still exist.
…for all Europe (except Kosovo)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am liking this a lot. Just a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG and documentation updates are missing.
@timtroendle I've addressed your issues but... On running the minimal workflow with updated zenodo pointer (to new potentials data that includes |
Will have a look at #239 soon. |
Minimal workflow now runs successfully, including |
nuts-year: | ||
description: Version of the Nomenclature of Territorial Units for Statistics to use in creating spatial units (see https://ec.europa.eu/eurostat/web/nuts/history for more info). | ||
type: number | ||
enum: [2013] # FIXME: enable other years |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't sound like a fixme to me.
…feature-ehighways-resolution Update ehighways resolution shape generation
…feature-ehighways-resolution Update ehighways resolution shape generation
…feature-ehighways-resolution Update ehighways resolution shape generation
Supercedes #336
Fixes #318
This is in response to a question you had @timtroendle around defining the shape source in
shapes
in the config. I went to clean up the unresolved comments from #336 and realised that it is a lot cleaner to take that approach. This PR leads to a less flexible solution - E-Highways is baked in more than in #336 - but it is cleaner.As with #336, it only works with NUTS2013, but I will open an issue about that and have a fix ready to go that I'll add via another PR.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.