Update ehighways resolution shape generation #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…on files and schemas.
Now need to implement the actual function properly.
Debug configuration set up also.
…nathan-peel/euro-calliope into feature-ehighways-resolution-unts-318
for more information, see https://pre-commit.ci
References to nuts-year "variable" still exist.
…for all Europe (except Kosovo)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
timtroendle
approved these changes
May 6, 2024
timtroendle
requested changes
May 6, 2024
|
@timtroendle I've addressed your issues but... On running the minimal workflow with updated zenodo pointer (to new potentials data that includes |
|
Will have a look at #239 soon. |
|
Minimal workflow now runs successfully, including |
timtroendle
approved these changes
May 14, 2024
| nuts-year: | ||
| description: Version of the Nomenclature of Territorial Units for Statistics to use in creating spatial units (see https://ec.europa.eu/eurostat/web/nuts/history for more info). | ||
| type: number | ||
| enum: [2013] # FIXME: enable other years |
There was a problem hiding this comment.
Doesn't sound like a fixme to me.
10 tasks
jnnr
pushed a commit
to jnnr/euro-calliope
that referenced
this pull request
Aug 27, 2024
…feature-ehighways-resolution Update ehighways resolution shape generation
jnnr
pushed a commit
to jnnr/euro-calliope
that referenced
this pull request
Aug 27, 2024
…feature-ehighways-resolution Update ehighways resolution shape generation
jnnr
pushed a commit
to jnnr/euro-calliope
that referenced
this pull request
Sep 3, 2024
…feature-ehighways-resolution Update ehighways resolution shape generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #336
Fixes #318
This is in response to a question you had @timtroendle around defining the shape source in
shapesin the config. I went to clean up the unresolved comments from #336 and realised that it is a lot cleaner to take that approach. This PR leads to a less flexible solution - E-Highways is baked in more than in #336 - but it is cleaner.As with #336, it only works with NUTS2013, but I will open an issue about that and have a fix ready to go that I'll add via another PR.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.