HMR hotfix #292
Merged
HMR hotfix #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Maybe it would be nice if you could spare few words as a comment to explain in code what's going on. Anyway GJ! Let's get merge it. |
zamotany
previously approved these changes
Nov 21, 2017
|
Let's add some comment as @jukben said. |
krizzu
force-pushed
the
krizzu/hmrHotFix
branch
from
67accbd
to
65ab36c
Compare
krizzu
force-pushed
the
krizzu/hmrHotFix
branch
from
65ab36c
to
c231863
Compare
|
Done, I hope that's explained enough |
zamotany
previously approved these changes
Nov 21, 2017
satya164
approved these changes
Nov 21, 2017
|
Ah, typos :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMR would thrown an error when it finds registered function that is on a prototype. With this patch, we just make sanity check if function is on
Object.prototype, if so, it's not a component.