fix: port setting in haul.config.js not used #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Aug 7, 2019
| @@ -22,7 +21,6 @@ export default function startCommand(runtime: Runtime) { | |||
| builder: { | |||
| port: { | |||
| description: 'Port to run your webpack server', | |||
| default: DEFAULT_PORT, | |||
There was a problem hiding this comment.
why removing from here? I guess it's still normalized later, but this feels like a proper place for a default port
There was a problem hiding this comment.
The thing is if I add it here the port from haul.config.js won't be picked up. Also we use port from the normalised config and there's a fallback to DEFAULT_PORT there as well:
port: env.port || get(projectConfig, 'server.port', DEFAULT_PORT),
thymikee
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#621