Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Speed up source map generation by only stringiying at the end #624

Merged
merged 1 commit into from
Aug 9, 2019
Merged

fix: Speed up source map generation by only stringiying at the end #624

merged 1 commit into from
Aug 9, 2019

Commits on Aug 8, 2019

  1. fix: Speed up source map generation by only stringiying at the end 

    Currently when generating source maps, we stringiyf the in-progress
indexMap once for every. single. file. even though we only care about
the final result (and indeed overwrite our previous stringification each
file). This was likely a typo and intended to be outside the forEach, so
this change moves the stringification to after we're fully done building
up the indexMap. This dramatically speeds up source map generation since
we're doing significantly less work with fewer allocations and GCs.
    @FuegoFro
    FuegoFro committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    b100ee2 View commit details
    Browse the repository at this point in the history