Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reads ANDROID_HOME for adb location #627

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

joelgallant
Copy link
Contributor

Summary

The ANDROID_HOME environment variable defines where to find platform tools like adb, and occasionally (my setup), these aren't in the global system PATH. This explicitly uses the path to access adb instead of relying on it being in the system PATH.

Test plan

No tests needed AFAIK - unless there is coverage here that I don't know about.

Copy link
Contributor

@zamotany zamotany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zamotany zamotany merged commit 9f71a69 into callstack:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants