Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: external bundles #633

Merged
merged 21 commits into from
Sep 9, 2019
Merged

feat: external bundles #633

merged 21 commits into from
Sep 9, 2019

Conversation

zamotany
Copy link
Contributor

@zamotany zamotany commented Aug 27, 2019

Adds a way to use pre-built (DLL) bundle when using multi-bundle command.

TODO

  • add support for bundlePath and manifestPath to multi-bundle command
  • add support for bundlePath and manifestPath to `packager server
  • serve source maps for pre-built bundle from packager server
  • add copyBundle option to automatically copy files to target directory
  • add integration test
  • monorepo fixture
  • monorepo integration test
  • add documentation
  • properly handle and resolve assets from pre-built bundle

@zamotany zamotany requested a review from thymikee August 27, 2019 10:26
@zamotany zamotany changed the title fat: external bundles feat: external bundles Aug 27, 2019
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

docs/Configuration.md Outdated Show resolved Hide resolved
docs/Configuration.md Outdated Show resolved Hide resolved
fixtures/monorepo/host/BundleRegistry.js Show resolved Hide resolved
docs/Configuration.md Show resolved Hide resolved
packages/haul-core/src/config/types.ts Outdated Show resolved Hide resolved
packages/haul-core/src/config/types.ts Outdated Show resolved Hide resolved
zamotany and others added 4 commits September 9, 2019 17:09
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
@zamotany zamotany merged commit 9f51eac into master Sep 9, 2019
@zamotany zamotany deleted the feat/external-bundle branch September 9, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants