Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only add plugin-transform-react-jsx-source in dev #640

Merged
merged 2 commits into from
Sep 16, 2019
Merged

fix: only add plugin-transform-react-jsx-source in dev #640

merged 2 commits into from
Sep 16, 2019

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented Sep 13, 2019 •
edited
Loading

Summary

Conditionally add @babel/plugin-transform-react-jsx-source so we don't get __source injected into production bundles, and reduce the bundle size.

Test plan

All current tests should pass.

@tido64
Copy link
Contributor Author

tido64 commented Sep 13, 2019

cc @zamotany @thymikee

zamotany
zamotany approved these changes Sep 14, 2019
View reviewed changes
Copy link
Contributor

@zamotany zamotany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 though I'm thinking if we should add support for BABEL_ENV as well.

@zamotany zamotany merged commit 27dee10 into callstack:master Sep 16, 2019
@tido64 tido64 deleted the tido64/remove-source branch September 16, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamotany zamotany zamotany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @zamotany