Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include react-native.config.js in published package #283

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

TMaszko
Copy link
Collaborator

@TMaszko TMaszko commented Feb 9, 2021

Summary

In this PR react-native.config.js has been added to the files in package.json because otherwise user that is using our package has to do it anyway himself.

@thymikee thymikee changed the title chore: included react-native config file to published package fix: included react-native config file to published package Feb 9, 2021
@thymikee thymikee changed the title fix: included react-native config file to published package fix: include react-native.config.js in published package Feb 9, 2021
@thymikee thymikee merged commit a218318 into master Feb 9, 2021
@thymikee thymikee deleted the include-react-native-config branch February 9, 2021 15:16
@mrousavy
Copy link
Collaborator

mrousavy commented Feb 9, 2021

I don't think we need that file

@thymikee
Copy link
Member

thymikee commented Feb 9, 2021

Yup we do

@mrousavy
Copy link
Collaborator

mrousavy commented Feb 9, 2021

Why? It's not included in any other packages I know - I'd have to try if it works without it though.

@thymikee
Copy link
Member

thymikee commented Feb 9, 2021

It's usually not needed, but this lib has an app/ directory with gradle setup that would normally be a part of android/ dir. @TMaszko is testing that at the moment, but this still isn't working as expected, so I guess we'll need to adjust the structure so it's the same as most of the libs out there.

@thymikee
Copy link
Member

thymikee commented Feb 9, 2021

@mrousavy would be great if you helped us testing releases 7.0.0 and 7.0.1 🙌🏼

@mrousavy
Copy link
Collaborator

mrousavy commented Feb 9, 2021

I see, for reference, here's how I structured it in react-native-blurhash.

@mrousavy would be great if you helped us testing releases 7.0.0 and 7.0.1 🙌🏼

I'm really busy with RN 0.64, Hermes & reanimated atm, but that's almost done so I'll see what I can do on the weekend/next week 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants