Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable prettier by default #57

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Feb 2, 2020

Summary

same as Kureev/react-native-blur#351

I removed "requirePragma": true from prettierrc because that option means prettier is not enabled unless explicitly turned on using the @format pragma (as it was in example/index.js).

After that I just ran eslint --fix and the code now follows the specified config.

Test Plan

eslint passes (it does locally :) )

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@Trancever
Copy link
Contributor

@vonovak Thanks!

@Trancever Trancever merged commit 2f40057 into master Feb 3, 2020
@Trancever Trancever deleted the @vonovak/fix-prettier-usage branch February 3, 2020 09:23
TimMun pushed a commit to TimMun/react-native-image-editor that referenced this pull request Sep 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants