-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fabric on Android #402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
force-pushed
the
chore/fabric-android
branch
from
July 25, 2022 23:19
c795e99
to
5360945
Compare
This PR is part of #380 - linking this to the issue. |
okwasniewski
changed the base branch from
chore/fabric-migration
to
chore/fabric-setup
July 26, 2022 08:59
okwasniewski
force-pushed
the
chore/fabric-android
branch
5 times, most recently
from
July 29, 2022 08:44
3f4c0b1
to
cf24a40
Compare
okwasniewski
force-pushed
the
chore/fabric-android
branch
from
July 29, 2022 17:46
cf24a40
to
48d9585
Compare
okwasniewski
changed the base branch from
chore/fabric-setup
to
chore/fabric-migration
August 2, 2022 18:11
okwasniewski
force-pushed
the
chore/fabric-android
branch
from
August 2, 2022 18:41
b734a21
to
3701d57
Compare
BartoszKlonowski
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some very minor comments, but it's totally well done!
Thank you! 👍
vertical?: ?boolean, | ||
tapToSeek?: ?boolean, | ||
tapToSeek?: WithDefault<boolean, false>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
Outdated
Show resolved
Hide resolved
package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
Outdated
Show resolved
Hide resolved
Merged
okwasniewski
added a commit
that referenced
this pull request
Aug 8, 2022
* Add fabric on iOS (#400) * Update podspec file for fabric * Define codegen spec & move import to separate file * Add codegenConfig in package.json * Update podspec to detect .mm files * Change spec types to floats * Implement fabric component with props updating * Re-order functions, add accessibilityIncrements prop * Clean up imports, remove comment * Sort out props updating, remove unused functions * Add event handling * Add tapToSeek implementation * Fix tapToSeek * Handle images using bridge * Add missing typedef * Verify the build for new arch with GH Actions * Save new-arch Pods under new-arch cache key * Use Podfile.lock with old arch and regenerate for new one * Correct path for new arch Podfile.lock creation * Disable flipper in Podfile * Install pods with new arch flag * Fix tapToSeek on iOS * Allow value property to be controlled * Generate project.pbxproj for new arch * Separate npm & pods step in CI * Change step names, fix cache keys * Remove pods cache * Run npm install if cache was not found * Run build using xcodebuild * Fix: Pods-related error after using Pods from cache (#407) * Bring back Pods to cache * Use new-arch string in key for new arch cache * Try to reinstall pods instead of creating new * Separate deps installation between two caches * Rename Pods reinstall step * Remove explicit folly version, default to old arch * Add clean scripts in example for codegen cleanup * Change CI step names * Remove isFabricEnabled This check is no longer needed. Co-authored-by: BartoszKlonowski <Bartosz.Klonowski@callstack.com> * Add fabric on Android (#402) * Configure build.gradle * Update libraryName on android * Create ReactSlider shared implementation * Split implementations into oldarch and newarch * Dispatch events * Cleanup eventDispatcher * Make oldarch implementation use shared code * Add defaults to js spec * Clean up newarch ReactSliderManager * Reorder props to fix disabled state * Handle TestID setter * Move ReactSliderShadowNode to shared implementation * Share getExportedCustomDirectEventTypeConstants * Remove comments, add empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Used examples / references:
Test Plan:
Test plan for RN <0.70:
newArchEnabled
to true insideexample/android/gradle.properties
example/android/app/src/main/jni/Android.mk
file.+ include $(NODE_MODULES_DIR)/@react-native-community/slider/android/build/generated/source/codegen/jni/Android.mk include $(CLEAR_VARS)
In the same file above, go to the
LOCAL_SHARED_LIBRARIES
setting and add the following line:libreact_codegen_rncore \ + libreact_codegen_ReactSlider \ libreact_debug \
example/android/app/src/main/jni/MainComponentsRegistry.cpp
Then, to launch the project run: