fix: hermes xcode build scripts (#133)

callstack · Aug 26, 2024 · 11d0bd5 · 11d0bd5
1 parent ff764e2
commit 11d0bd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh b/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh
@@ -31,6 +31,9 @@ function get_deployment_target {
     elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then
       echo "${XROS_DEPLOYMENT_TARGET}"
       return
+    elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then
+      echo ${XROS_DEPLOYMENT_TARGET}
+      return
     fi
 
     echo "${IPHONEOS_DEPLOYMENT_TARGET}"

diff --git a/packages/react-native/template/visionos/HelloWorld/AppDelegate.swift b/packages/react-native/template/visionos/HelloWorld/AppDelegate.swift
@@ -9,7 +9,7 @@ class AppDelegate: RCTAppDelegate {
 
   override func bundleURL() -> URL? {
 #if DEBUG
-    RCTBundleURLProvider.sharedSettings()?.jsBundleURL(forBundleRoot: "index")
+    RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
 #else
     Bundle.main.url(forResource: "main", withExtension: "jsbundle")
 #endif