fix: hermes xcode build scripts (#133)

callstack · Apr 30, 2024 · a600bfb · a600bfb
1 parent 20d4153
commit a600bfb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh b/packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh
@@ -16,10 +16,7 @@ function get_platform_copy_destination {
     if [[ $1 == "macosx" ]]; then
       echo "macosx"
       return
-    elif [[ $1 == "xros" ]]; then
-      echo "xros"
-      return
-    elif [[ $1 == "xrsimulator" ]]; then
+    elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then
       echo "xros"
       return
     fi
@@ -31,8 +28,10 @@ function get_deployment_target {
     if [[ $1 == "macosx" ]]; then
       echo ${MACOSX_DEPLOYMENT_TARGET}
       return
+    elif [[ $1 == "xrsimulator" || $1 == "xros" ]]; then
+      echo ${XROS_DEPLOYMENT_TARGET}
+      return
     fi
-
     echo ${IPHONEOS_DEPLOYMENT_TARGET}
 }
 

diff --git a/packages/react-native/template/visionos/HelloWorld/AppDelegate.swift b/packages/react-native/template/visionos/HelloWorld/AppDelegate.swift
@@ -9,7 +9,7 @@ class AppDelegate: RCTAppDelegate {
 
   override func bundleURL() -> URL? {
 #if DEBUG
-    RCTBundleURLProvider.sharedSettings()?.jsBundleURL(forBundleRoot: "index")
+    RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
 #else
     Bundle.main.url(forResource: "main", withExtension: "jsbundle")
 #endif