Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward measure warnings to compare #537

Closed
wants to merge 2 commits into from

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Oct 22, 2024

Summary

This PR allows forwarding errors happening during measure step to be displayed in the compare report.

Test plan

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: d6dae69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Performance Comparison Report

  • Current: HEAD (0713374) - 2024-10-22 15:47:09Z
  • Baseline: main (20f5746) - 2024-10-22 15:46:24Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 81.6 ms → 82.5 ms (+0.9 ms, +1.1%) 7 → 7
fib 30 function 38.5 ms → 38.1 ms (-0.4 ms, -1.1%) 1 → 1
fib 31 function 62.1 ms → 61.8 ms (-0.3 ms, ±0.0%) 1 → 1
fib 32 function 100.6 ms → 101.2 ms (+0.6 ms, +0.6%) 1 → 1
InitialRenders 1 render 1.2 ms → 1.2 ms (+0.0 ms, +2.4%) 2 → 2
InitialRenders 3 render 1.2 ms → 1.2 ms (-0.0 ms, ±0.0%) 4 → 4
ManyRenderIssues render 1.4 ms → 1.3 ms (-0.0 ms, -2.0%) 5 → 5
RedundantUpdates render 0.8 ms → 0.8 ms (-0.0 ms, -2.6%) 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 81.6 ms
Stdev: 0.3 ms (0.3%)
Runs: 81.7 81.9 81.4 81.8 81.8 81.3 81.5 81.6 82.1 81.3
Warmup runs: 85.2

Current
Mean: 82.5 ms
Stdev: 0.8 ms (1.0%)
Runs: 81.3 82.0 83.1 82.9 81.6 83.7 83.8 82.4 82.4 82.0
Warmup runs: 97.0
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 38.5 ms
Stdev: 0.2 ms (0.5%)
Runs: 38.6 38.6 38.8 38.5 38.9 38.4 38.4 38.4 38.3 38.5
Warmup runs: 36.1

Current
Mean: 38.1 ms
Stdev: 0.9 ms (2.3%)
Runs: 38.4 38.4 38.4 38.4 38.4 38.4 38.3 35.6 38.4 38.4
Warmup runs: 44.6
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.1 ms
Stdev: 0.0 ms (0.1%)
Runs: 62.1 62.1 62.2 62.1 62.2 62.2 62.2 62.1 62.2 62.1
Warmup runs: 62.3

Current
Mean: 61.8 ms
Stdev: 1.4 ms (2.2%)
Runs: 58.0 62.1 62.1 62.1 62.1 62.1 62.1 62.3 62.8 62.8
Warmup runs: 62.3
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 100.6 ms
Stdev: 0.1 ms (0.1%)
Runs: 100.8 100.6 100.5 100.5 100.6 100.6 100.6 100.5 100.6 100.5
Warmup runs: 100.7

Current
Mean: 101.2 ms
Stdev: 0.5 ms (0.5%)
Runs: 100.6 100.5 100.5 100.9 101.6 101.6 101.6 101.5 101.6 101.6
Warmup runs: 100.9
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 1.2 ms
Stdev: 0.2 ms (21.5%)
Runs: 1.6 1.5 1.1 1.2 1.2 0.8 1.1 1.0 0.9 1.2
Warmup runs: 150.7

Current
Mean: 1.2 ms
Stdev: 0.4 ms (35.1%)
Runs: 2.3 1.3 1.1 1.2 1.1 0.9 1.1 1.0 0.8 1.0
Warmup runs: 9.8
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.2 ms
Stdev: 0.1 ms (4.2%)
Runs: 1.2 1.3 1.2 1.2 1.2 1.2 1.2 1.2 1.2 1.3
Warmup runs: 1.2

Current
Mean: 1.2 ms
Stdev: 0.1 ms (6.8%)
Runs: 1.2 1.4 1.2 1.2 1.2 1.2 1.2 1.1 1.1 1.3
Warmup runs: 1.2
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.4 ms
Stdev: 0.0 ms (2.3%)
Runs: 1.4 1.4 1.3 1.4 1.4 1.4 1.4 1.4 1.4 1.3
Warmup runs: 1.4

Current
Mean: 1.3 ms
Stdev: 0.0 ms (1.7%)
Runs: 1.3 1.3 1.3 1.4 1.3 1.4 1.4 1.3 1.3 1.4
Warmup runs: 1.3
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
RedundantUpdates render Baseline
Mean: 0.8 ms
Stdev: 0.0 ms (6.0%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.8 0.9 0.8 0.8 1.0
Warmup runs: 0.8

Current
Mean: 0.8 ms
Stdev: 0.0 ms (3.3%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.9
Warmup runs: 0.8
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Async Component 1 🔴 -
AsyncComponent 1 🔴 -
AsyncComponent 20 runs 1 🔴 -
AsyncComponent - no wait 1 🔴 -

Added Entries

Show entries
Name Type Duration Count
AsyncComponent render 52.4 ms 4
AsyncComponent - no wait render 31.7 ms 2
AsyncComponent 20 runs render 53.4 ms 4
Show details
Name Type Duration Count
AsyncComponent render Current
Mean: 52.4 ms
Stdev: 0.3 ms (0.5%)
Runs: 51.9 52.6 52.2 52.0 52.3 52.6 52.5 52.8 52.6 52.5
Warmup runs: 57.6
Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
AsyncComponent - no wait render Current
Mean: 31.7 ms
Stdev: 0.2 ms (0.8%)
Runs: 31.9 31.5 31.5 31.7 31.8 32.0 31.6 31.5 32.2 31.5
Warmup runs: 31.3
Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
AsyncComponent 20 runs render Current
Mean: 53.4 ms
Stdev: 2.4 ms (4.4%)
Runs: 52.4 52.7 52.5 52.3 52.7 54.3 52.3 58.5 52.0 52.0 52.4 59.3 52.2 52.3 52.2 58.4 52.1 52.5 52.1 52.0
Warmup runs: 53.1
Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Removed Entries

Show entries
Name Type Duration Count
Other Component render 53.5 ms 4
Other Component 20 run render 52.4 ms 4
Show details
Name Type Duration Count
Other Component render Baseline
Mean: 53.5 ms
Stdev: 4.0 ms (7.4%)
Runs: 51.4 52.0 52.2 52.1 52.5 52.4 52.2 52.6 52.6 64.8
Warmup runs: 58.5
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 run render Baseline
Mean: 52.4 ms
Stdev: 0.4 ms (0.8%)
Runs: 52.1 52.8 52.6 52.1 52.5 52.6 53.9 52.1 51.9 52.0 52.3 52.2 52.3 52.5 52.7 52.0 52.4 52.2 52.3 52.0
Warmup runs: 53.1
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Generated by 🚫 dangerJS against d6dae69

@mdjastrzebski
Copy link
Member Author

Closing as no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant