feat: implement simple cache for config #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
feat/simple-cache
branch
3 times, most recently
from
179c951 to
474c823
Compare
grabbou
reviewed
Nov 24, 2024
okwasniewski
force-pushed
the
feat/simple-cache
branch
from
474c823 to
dab36ae
Compare
|
Looking good but needs rebase XD |
okwasniewski
force-pushed
the
feat/simple-cache
branch
from
f634739 to
c58246b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements simple cache for config so it's retrieve only once. Also the config now has proper types 👍🏻