Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios build on old xcode #144

Merged

Conversation

juliesaia-vendora
Copy link
Contributor

@juliesaia-vendora juliesaia-vendora commented Nov 12, 2024

Version >=0.5.0 was failing to build on XCode 15.2:

func introspectTabView(closure: @escaping (UITabBarController) -> Void) -> some View {
  44 |     self
> 45 |       .introspect(
     |        ^ call to main actor-isolated instance method 'introspect' in a synchronous nonisolated context

I think it's related to a recent change to @mainactor in XCode 16?

Whatever the case, the package is building for me with this change 🙌

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@okwasniewski okwasniewski merged commit 04eea94 into callstackincubator:main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants