Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
high-level summary
get_test_dates()
in order to:dbt_date_integration_tests
's_get_utils_namespaces()
to align withdbt-utils
's strategy of joining integration test macros to the dispatch list. (note: this will certainly change withv0.20.0
, but at least it's a step in the right direction.detail
resolves: #25
given that the only difference in
get_test_dates()
is theweek_of_year
column, this will make it easier to shim.once this merges, making
get_test_dates()
working for TSQL will be as simple as adding this macro to thetsql-utils
dbt-date integration tests macros folder (see: dbt-msft/tsql-utils#48)