Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new tests tsql compat #32

Closed
wants to merge 3 commits into from

Conversation

dataders
Copy link
Contributor

necessary updates per #30. It seems there's some fast-moving goal posts for getting dbt-date integration tests passing for the dbt-msft adapters.

I'm struggling to work with the new nested CTEs and ephemeral model that was introduced in the PR.

Double struggle because I thought that this change would at least disable these new models from being run and tested.

models:
  dbt_date_integration_tests:
    dates: &disabled
        +enabled: false
    dim_week: *disabled
    dim_hour: *disabled

@dataders
Copy link
Contributor Author

dataders commented May 31, 2021

@clausherther maybe we can mind meld next week on how to untangle the CTEs? My changes were of no use.

in the meantime, i'm going to disable dbt-date testing from tsql-utils' CI for the time being so I can finally get dbt-msft/tsql-utils#45 merged (and start saving some money by not having Synapse run 24/7)

@clausherther
Copy link
Contributor

clausherther commented May 31, 2021

Ah, sorry, I didn't realize TSQL doesn't support ephemeral models and nested CTEs. I'll keep that in mind! Since I can't test on SQL Server, these sort of things can easily slip by unfortunately.

Happy to get on a quick chat this week, feel free to reach out on dbt Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants