Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to support dbt 0.1.x #50

Merged
merged 8 commits into from
Dec 5, 2021
Merged

Upgrade project to support dbt 0.1.x #50

merged 8 commits into from
Dec 5, 2021

Conversation

clausherther
Copy link
Contributor

Updates the following files to support dbt==0.1.x

  • .gitignore
  • dbt_project.yml
  • packages.yml
  • integration_tests/dbt_project.yml

@clausherther
Copy link
Contributor Author

cc: @joellabes

@joellabes
Copy link

Looks good! My only nitpick is that it'd be nice to also (and probably first) release a 0.4.2 patch which allows dbt [">=0.20.0", "<1.1.0"] - there's one breaking change in dbt-utils 0.8.0, and if people aren't able to move to that I'd like them to still be able to get onto Core 1.0.

@clausherther
Copy link
Contributor Author

clausherther commented Dec 5, 2021

@joellabes thinking about this some more: while I agree that'd be nice, I don't think I'll have the brainspace this week to handle the resulting doubled-up package dependencies between a patch for dbt-date and dbt-expectations, in addition to the already too tightly linked main branches.
Actually I think what you're saying is do the 0.4.2 release first, and a 0.4.7 release on dbt-exp, then a second set of PRs for 0.5.0 on both. I think that'll work. I just didn't want to maintain an old branch.

@clausherther clausherther merged commit cf9b6d6 into main Dec 5, 2021
@clausherther clausherther deleted the upgrade/dbt-1-0 branch December 5, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants