Add component attributes to builder #1927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to add attributes to components within the builder. This is needed as part of our AXI-wrapper generator #1733
Something like:
will produce a component signature that looks like:
I added note of this in the reference doc. Didn't think this warranted changing/adding any tests but can do that if we want.
I made sure this works with a little snippet of python uses this, but didn't think it was warranted to go into the repo, included here for completeness:
emits: