Greatly improve performance of channel settings emote list #599
Conversation
The channel settings emote list is now paginated and leverages the same basic code as the emote browser, but with a different renderer. Fixes #594 and kills an ugly function.
| return; | ||
| } | ||
| var end = Math.min(start + this.itemsPerPage, this.emotes.length); | ||
| var self = this; |
There was a problem hiding this comment.
Closing the edit dialogue jumps you back to page 1. 😡 That's gonna piss me off (and probably others) to no end. It's especially annoying since it happens even if you haven't modified it.
var self = this; this.page = page;
|
Damn, you beat me to it. Of course your code looks much nicer than what I would have thought of initially 😥 Longstanding annoyance (affects the emotelist too): The prev |
| row.appendChild(tdDelete); | ||
|
|
||
| // Add emote name | ||
| // TODO: editable |
There was a problem hiding this comment.
This seems like busy work I could handle after this is merged.
|
While you're at it, you could move showChannelSettings, startQueueSpinner, and stopQueueSpinner (lines 3017-3062) right above EmoteList, that way the emote list classes are directly adjacent to each other and it doesn't hurt the organization of the rest of the file any. Just an idea. |
|
The client is going to be factored out to use webpack or something similar to break it down into smaller modules. At that time, EmoteList and CSEmoteList will become separate files in the source tree that depend one on the other. |
|
Pushing to beta, the paginator button spacing issue can be the subject of a different change. |
|
Tested. Looks ready for merge. |
The channel settings emote list is now paginated and leverages the same
basic code as the emote browser, but with a different renderer. Fixes
#594 and kills an ugly function.