Add a service socket #603
Merged
Add a service socket #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }) | ||
| } | ||
| } else if (line.indexOf("/clearban") === 0) { |
There was a problem hiding this comment.
/unglobalban or something like that would be more consistent naming.
Replace the IP address regex with net.isIPv4(): https://nodejs.org/api/net.html#net_net_isipv4_input
Xaekai
force-pushed
the
servicesocket
branch
2 times, most recently
from
07b41c5 to
4010ee9
Compare
|
Updated. |
| @@ -75,5 +76,31 @@ function handleLine(line) { | |||
| } | |||
| } else if (line.indexOf("/reload-partitions") === 0) { | |||
| sv.reloadPartitionMap(); | |||
| } else if (line.indexOf("/globalban") === 0) { | |||
| var args = line.split(" "); args.shift(); | |||
| if (args.length === 2 && net.isIPv4(args[0]) || net.isIPv6(args[0])) { | |||
There was a problem hiding this comment.
Operator precedence means that this is parsed as (args.length === 2 && net.isIPv4(args[0])) || net.isIPv6(args[0]), also if you want to support both you can just check if net.isIP() is nonzero.
Xaekai
force-pushed
the
servicesocket
branch
3 times, most recently
from
f832ca5 to
3cd9d71
Compare
|
Updated and retested. |
Add one more command to the service commandline
| @@ -45,6 +45,7 @@ process.stdin.on("data", function (data) { | |||
| } | |||
| }); | |||
|
|
|||
| var net = require('net'); | |||
There was a problem hiding this comment.
It's not unused. It's used to to validate user input, which was your suggestion over a regex.
Edit: I can change it to just import the one function though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to enable out of band access to the process commandline