Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that caused different form autocomplete listings to be displayed #755

Merged

Conversation

JIIOryo
Copy link
Contributor

@JIIOryo JIIOryo commented Oct 15, 2023

Summary

Fixed a bug that could cause a list of autocompletes for different forms to be displayed when using multiple autocompletes at the same time.

The cause was that when using Date.now() to generate autocompleteId, there was a high probability that the same id would be generated for a nearby form.

The id generation logic mimics the following code.

const id = useMemo<string>(() => `text-input-${Math.random()}`, []);

Before

After

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

🦋 Changeset detected

Latest commit: 9dadda7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viron/app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nonoakij nonoakij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants