Fixed a bug that caused different form autocomplete listings to be displayed #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug that could cause a list of autocompletes for different forms to be displayed when using multiple autocompletes at the same time.
The cause was that when using Date.now() to generate autocompleteId, there was a high probability that the same id would be generated for a nearby form.
The id generation logic mimics the following code.
viron/packages/app/src/components/textinput/index.tsx
Line 45 in 7607169
Before
After