Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring25 M3 v0.3.0 #147

Merged
merged 23 commits into from
Feb 11, 2025
Merged

Spring25 M3 v0.3.0 #147

merged 23 commits into from
Feb 11, 2025

Conversation

FabrizioMoggio
Copy link
Collaborator

This PR is the final PR for Spring25 M3.

What type of PR is this?

  • documentation
  • release management

What this PR does / why we need it:

  • This PR implements the scope for Spring25
  • The PR updates all the file in terms of release number referring to r2.1 and version v0.3.0-rc.1.
  • Updates the CHANGELOG.md file

Which issue(s) this PR fixes:

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments and typos.
/LGTM from release management


**Please be aware that the project will have frequent updates to the main branch. There are no compatibility guarantees associated with code in any branch, including main, until it has been released. For example, changes may be reverted before a release is published. For the best results, use the latest published release.**

The below sections record the changes for each API version in each release as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this paragraph is not the latest version of this section from the CHANGELOG_TEMPLATE.md:

it should say:

The below sections record the changes for each API version in each release as follows:

  • for an alpha release, the delta with respect to the previous release
  • for the first release-candidate, all changes since the last public release
  • for subsequent release-candidate(s), only the delta to the previous release-candidate
  • for a public release, the consolidated changes since the previous public release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated
* https://github.com/camaraproject/CallForwardingSignal/pull/117
* https://github.com/camaraproject/CallForwardingSignal/pull/121

**Full Changelog**: https://github.com/camaraproject/CallForwardingSignal/commits/r2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally, this line contains the "diff" as per the above 4 bullets in my previous comment.

so it would say:

r1.3...r2.1

which can be obtained by doing a compare between the previous release and a draft release of the r2.1 (which you can delete after doing the compare.

same comment would apply to line 86 in r1.3 part

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 142: the version number of x-camara-commonalities now should be either the main number x or 0.y - so in this case put: 0.5 for ease of maintenance.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,4 @@
Feature: CAMARA Call Fowarwing Signal API, v1.0.0 - Operation call-forwardings
Feature: CAMARA Call Fowarwing Signal API, v0.3.0-rc.1 - Operation call-forwardings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: Fowarwing -> Forwarding

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 113: typo: property --> properly
line 122: typo: ivalid --> invalid

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,4 @@
Feature: CAMARA Call Fowarwing Signal API, v1.0.0 - Operation unconditional-call-forwarding
Feature: CAMARA Call Fowarwing Signal API, v0.3.0-rc.1 - Operation unconditional-call-forwarding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Fowarwing -> Forwarding

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other typos:
line 92: property --> properly
line 101: ivalid --> invalid

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FabrizioMoggio
Copy link
Collaborator Author

@bigludo7 , @chinaunicomyangfan can you please have a look and review the PR, so that when we have the "go" from the Meta Release Review team we can merge. All the comments have been addressed, according to my understanding.

bigludo7
bigludo7 previously approved these changes Jan 31, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @FabrizioMoggio for the heads-up !

@@ -1,20 +1,20 @@

# API Readiness Checklist

Checklist for API call-forwarding-signal v1.0.0 in r2.0
Checklist for API call-forwarding-signal v0.3.0-rc.1 in r2.1


| Nr | API release assets | alpha | release-candidate | public-release<br>initial | public-release<br> stable | Status | Comments |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot one point: need to update to the latest version of the checklist:
https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API-Readiness-Checklist.md

  • rename the last column to "Reference information"
  • fill the lines 2 and 3 with the Comm & ICM release respectively (short link: "r2.2")

@FabrizioMoggio FabrizioMoggio mentioned this pull request Feb 10, 2025
Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, you're all set !
/LGTM from release mgmt

@FabrizioMoggio
Copy link
Collaborator Author

@bigludo7 , @chinaunicomyangfan can you please review the PR, we already have the approval from the RM team.

Copy link
Collaborator

@chinaunicomyangfan chinaunicomyangfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabrizioMoggio FabrizioMoggio merged commit 69c0911 into camaraproject:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants