Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with PR#22: doc(Usage of discriminator): Encourage inheritance rather than polymorphism #62

Closed
rartych opened this issue Sep 13, 2023 · 0 comments · Fixed by #64
Closed

Problem with PR#22: doc(Usage of discriminator): Encourage inheritance rather than polymorphism #62

rartych opened this issue Sep 13, 2023 · 0 comments · Fixed by #64
Assignees
@patrice-conil

Comments

@rartych
Copy link
Collaborator

rartych commented Sep 13, 2023

Problem description
Merge of PR#55 seems to have compromised PR#22.

Expected action

Resubmit the changes in API Design Guidelines 11.5.1 Usage of discriminator

Additional context
patrice-conil added a commit to patrice-conil/Commonalities that referenced this issue Sep 18, 2023
@patrice-conil
Re-integrate content from camaraproject#22 due to revert in camarapro…
28420f3 
…ject#55.

Fix camaraproject#62
Signed-off-by: Patrice Conil <patrice.conil@orange.com>

Signed-off-by: Patrice Conil <patrice.conil@orange.com>
@patrice-conil patrice-conil mentioned this issue Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrice-conil patrice-conil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-integrate content from #22 due to revert in #55. patrice-conil/Commonalities
2 participants
@patrice-conil @rartych