Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]: Linting rules problem with Traffic Influence API #161 #169

Conversation

VijayKesharwani
Copy link
Contributor

@VijayKesharwani VijayKesharwani commented Mar 22, 2024

What type of PR is this?

Add one of the following kinds:

  • bug

What this PR does / why we need it:

Fixing camara-http-method rule to include parameters as valid identifier under path.

Which issue(s) this PR fixes:



Fixes #161

Special notes for reviewers:

Hello Team,
As per the issue #161, this PR solves the problem of giving error on using 'parameters' under path for traffic Influence API yaml file related to camara-http-method linting rule.

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

…ier under path.

Fixing camara-http-method rule to include parameters as valid identifier under path.
@rartych
Copy link
Collaborator

rartych commented Mar 25, 2024

In order to have simple versioning of linting configuration I would modify the line 3 to sth like:
# 19.03.2024 - camara-http-method rule corrected

Updating change header in .spectral.yml
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabrizioMoggio
Copy link
Collaborator

FabrizioMoggio commented Apr 10, 2024

Can this fix be merged?

@rartych
Copy link
Collaborator

rartych commented Apr 10, 2024

@FabrizioMoggio Is it possible for you to test it?
I guess the fix works well,
If you approve it, it can be merged quickly.

@FabrizioMoggio
Copy link
Collaborator

Tested in the TI API, it works.

@rartych
Copy link
Collaborator

rartych commented Apr 15, 2024

@FabrizioMoggio Thank you for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting rules problem with Traffic Influence API
5 participants