Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guideline_for_datacontenttype_cloudevent_concept_as_enum #193

Merged

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

  • correction
  • enhancement/feature

What this PR does / why we need it:

By means of this PR, two topics are covered:

Which issue(s) this PR fixes:

Fixes #192

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

N/A

@PedroDiez PedroDiez added enhancement New feature or request correction correction in documentation labels May 2, 2024
@PedroDiez PedroDiez self-assigned this May 2, 2024
@PedroDiez PedroDiez requested a review from bigludo7 May 2, 2024 17:45
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@PedroDiez
Copy link
Collaborator Author

If no additional comments i will merge monday next week

@PedroDiez PedroDiez merged commit c0f4656 into main May 20, 2024
@rartych rartych deleted the guideline_for_datacontenttype_cloudevent_concept_as_enum branch October 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common Design Model for Cloud Event datacontenttype field
4 participants