Update API-design-guidelines.md-with-wildcard-scopes-icm-agreement #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilpa-padgaonkar
requested review from
rartych,
patrice-conil,
RubenBG7 and
PedroDiez
as code owners
|
@AxelNennker and @jpengar Could you kindly check if the section "API-level scopes" reflects correctly the agreement made in camaraproject/IdentityAndConsentManagement#95 @PedroDiez and @bigludo7 : I have simply duplicated the content of #177 into the section 11.6.1 to ensure consistency. Could you kindly take a look? |
jpengar
approved these changes
Jun 5, 2024
jpengar
approved these changes
Jun 5, 2024
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
rartych
reviewed
Jun 5, 2024
rartych
reviewed
Jun 5, 2024
jpengar
reviewed
Jun 5, 2024
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
rartych
approved these changes
Jun 5, 2024
AxelNennker
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR includes the following changes:
Documents the agreement in ICM on wildcard scopes discussed under the issue -(Scope at "API level" feedback from country market implementation IdentityAndConsentManagement#95) into the design guidelines to ensure completeness of the doc,
The explicit subscriptions related scope changes were documented in the PR update-design-doc-with-explicit-sub-scope-changes #177 . The scope naming is described in 2 sections in the design doc - 10.2 and 11.6.1. The earlier PR only updated section 10.2 (b). This PR adds the needed content also in section 11.6.1
Which issue(s) this PR fixes:
Fixes #184
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.