Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public release name #35

Merged
merged 45 commits into from
Jul 4, 2024

Conversation

tanjadegroot
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • cleanup
  • documentation

What this PR does / why we need it:

It removes the "-" from public-release and others as described in the issue below
Also fixed some links and removes some duplicate text about GitHub release feature

Which issue(s) this PR fixes:

Fixes #34

Special notes for reviewers:

No content change - please reveew and merge

Changelog input

update of API version and release type naming to remove "-". Issue #34 

Additional documentation

@hdamker hdamker requested a review from a team June 17, 2024 06:10
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes regarding the release naming are all looking good, just few comments about other changes.

documentation/API-Readiness-Checklist.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
tanjadegroot and others added 3 commits June 19, 2024 18:50
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Update per Herbert comment to refer to the readiness checklist
hdamker
hdamker previously approved these changes Jun 20, 2024
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tanjadegroot

@hdamker hdamker requested a review from a team June 20, 2024 13:54
@tanjadegroot
Copy link
Collaborator Author

Please hold reviews of this PR untill I include updates following new comments received form Herbert

@hdamker hdamker self-requested a review June 25, 2024 15:11
@tanjadegroot tanjadegroot marked this pull request as draft June 25, 2024 15:13
@tanjadegroot tanjadegroot marked this pull request as ready for review June 28, 2024 00:24
@tanjadegroot
Copy link
Collaborator Author

@hdamker @soadeyemo and others, please review

@hdamker
Copy link
Collaborator

hdamker commented Jul 2, 2024

@camaraproject/release-management_maintainers: please review at latest until Wednesday July 3rd, until eob.

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the content looks good to me. Most of the following comments are smaller issues. I have looked mainly for consistency. The alignment with the milestone definitions might need a short discussion.

documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
documentation/API_Release_Guidelines.md Outdated Show resolved Hide resolved
soadeyemo
soadeyemo previously approved these changes Jul 2, 2024
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
tanjadegroot and others added 24 commits July 3, 2024 13:17
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
some text tweeks following Herbert's review comments
tentative update of the sentence line 35
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soadeyemo soadeyemo self-requested a review July 4, 2024 18:41
@soadeyemo soadeyemo merged commit d8a4064 into camaraproject:main Jul 4, 2024
@tanjadegroot tanjadegroot deleted the Update-public-release-name branch July 26, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of API version type and release type naming
3 participants