Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of changelog template and example #36

Merged
merged 45 commits into from
Jul 2, 2024

Conversation

tanjadegroot
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

The template of the CHANGELOG was adapted to the Release Management Process and to account for multiple APIs in an API Sub Project release. The template file is moved from Commonalities to Release Management.

Which issue(s) this PR fixes:

Fixes #25

Special notes for reviewers:

Changelog input

- CHANGELOG template was adapted to the Release Management Process 
- take into account having multiple APIs in an API Sub Project release.
- Move file form Commonalities to Release Management

Additional documentation

soadeyemo
soadeyemo previously approved these changes Jun 19, 2024
Copy link
Collaborator

@soadeyemo soadeyemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.

@hdamker hdamker requested a review from a team June 19, 2024 11:24
@rartych
Copy link
Collaborator

rartych commented Jun 19, 2024

The Commonalities template is currently in SupportingDocuments:

https://github.com/camaraproject/Commonalities/blob/main/documentation/SupportingDocuments/CHANGELOG_TEMPLATE.md

Should it be removed or deprecated?

@hdamker
Copy link
Collaborator

hdamker commented Jun 20, 2024

@rartych

Should it be removed or deprecated?

As discussed within TSC: in the current release "deprecated" with a text similar to https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Readiness-Checklist.md. To be deleted in a later release.

@rartych
Copy link
Collaborator

rartych commented Jun 21, 2024

As discussed within TSC: in the current release "deprecated" with a text similar to https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Readiness-Checklist.md. To be deleted in a later release.

Solved in camaraproject/Commonalities#239

documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_EXAMPLE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_TEMPLATE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_TEMPLATE.md Outdated Show resolved Hide resolved
documentation/CHANGELOG_TEMPLATE.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Collaborator

hdamker commented Jun 21, 2024

Sorry for the many comments ... I tried to "rewrite" the example via suggestions which was maybe not the best idea. An alternative to the use of the QoD CHANGELOG as the base for the example could be to write a much simpler but hypothetical one.

Some of the comments within the example are also relevant for the template.

proposal Herbert

Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Comments herbert: 
- put back original Changelog for v0.9.0 and older
- removed backward compatibility statements in references section
herbert's comments 2
update after herbert comments
update after herbert comments
updated fake URLs with release numbers iso API version numbers
changed titles to be a bit more meaningful
crosse checked all Herbert comments - ready for review
cross checked all herbert's comments - ready for review.
update in RM call
@hdamker hdamker marked this pull request as draft June 25, 2024 15:25
tanjadegroot and others added 7 commits June 25, 2024 17:55
update on RM call
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
final comments Herbert
final comments Herbert
final comments Herbert
Changelog - input following Herbert's comments
@tanjadegroot tanjadegroot marked this pull request as ready for review June 25, 2024 18:14
@tanjadegroot tanjadegroot marked this pull request as draft June 26, 2024 00:34
remove older versions and propagate changes to rc and public (to be continued)
final comments Herbert
@tanjadegroot tanjadegroot marked this pull request as ready for review June 26, 2024 20:51
@tanjadegroot
Copy link
Collaborator Author

@hdamker @soadeyemo and others, please review

@soadeyemo soadeyemo self-requested a review July 2, 2024 16:21
@soadeyemo soadeyemo merged commit b855feb into camaraproject:main Jul 2, 2024
@tanjadegroot tanjadegroot deleted the Update-of-Changelog-template branch July 26, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants