Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44 create api review issue template #45

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

tanjadegroot
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature
  • subproject management

What this PR does / why we need it:

Issue template for coordinating API release PR reviews by the Release Mgmt team

Which issue(s) this PR fixes:

Fixes #44

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@tanjadegroot
Copy link
Collaborator Author

@hdamker please check if this issue template looks OK.
Given current content, I do not see any need to update the config.yaml file (unless it should be tailored more to the RM working group)

hdamker
hdamker previously approved these changes Jul 24, 2024
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just a suggestion

.github/ISSUE_TEMPLATE/issue_review_template Outdated Show resolved Hide resolved
@hdamker
Copy link
Collaborator

hdamker commented Jul 24, 2024

Given current content, I do not see any need to update the config.yaml file (unless it should be tailored more to the RM working group)

Correct, let's do the tailoring within a separate issue.

@hdamker
Copy link
Collaborator

hdamker commented Jul 24, 2024

@tanjadegroot Let me know if I should merge it - I don't think we need a further review for that.

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@tanjadegroot
Copy link
Collaborator Author

@hdamker - yes, greate suggestions and please merge

@hdamker hdamker merged commit 940b979 into camaraproject:main Jul 24, 2024
@tanjadegroot tanjadegroot deleted the 44-create-api-review-issue-template branch July 26, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an api-review issue template for use by release management
2 participants