Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of broken links in CHANGELOG.md #135

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Aug 9, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Correct the links to raw YAML file for Redoc and Swagger (removed blob/)

Which issue(s) this PR fixes:

n/a - minor change

Special notes for reviewers:

Update r1.1 release description as well.

Copy link

github-actions bot commented Aug 9, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 3.28s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.81s
✅ YAML yamllint 2 0 0.5s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

Corrected links for sim-swap-subscriptions
@hdamker
Copy link
Collaborator Author

hdamker commented Aug 9, 2024

Same for sim-swap-subscription links.

Note: the sim-swap-subscription part from CHANGELOG.md is not in the r1.1 release description. Is this by intention? @fernandopradocabrillo

@fernandopradocabrillo
Copy link
Collaborator

Same for sim-swap-subscription links.

Note: the sim-swap-subscription part from CHANGELOG.md is not in the r1.1 release description. Is this by intention? @fernandopradocabrillo

No, it's a mistake, I'll fix it tight now

@fernandopradocabrillo fernandopradocabrillo merged commit 75f1919 into main Aug 9, 2024
1 check passed
@hdamker hdamker deleted the hdamker-patch-1 branch August 9, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants