Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BYON-CallHandling-Service.yaml - 201 session created, 200 session updated, 204 session updated & examples #44

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

deepakjaiswal1
Copy link
Collaborator

What type of PR is this?

This PR updates the Swagger documentation for the BYON-CallHandling-Service:
a) Adds a 201 Created response for the (POST) VoIP session creation.
b) Adds a 204 No Content response for updating (PUT) VoIP session status when no response body is received.
c) Updates the 200 OK response for updating (PUT) VoIP session status when a response body is received.
d) Adds examples.

@deepakjaiswal1
Copy link
Collaborator Author

@pradeepachar-mavenir @TEF-RicardoSerr Please review the changes in this PR.

Copy link
Collaborator

@TEF-RicardoSerr TEF-RicardoSerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented in the meeting, looks good overall, it is just needed to adreess the errors raised by megalinter

@deepakjaiswal1
Copy link
Collaborator Author

@TEF-RicardoSerr @pradeepachar-mavenir Removed MegaLinter errors.

Copy link
Collaborator

@TEF-RicardoSerr TEF-RicardoSerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TEF-RicardoSerr TEF-RicardoSerr merged commit 7ec4ea5 into camaraproject:main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants