Add example and introduce FlowchemDeviceClients
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advertize for devices not components, skip name validation in zeroconfig but enforce before at config parsing level.
notably including max device name
They can be fetch by there, mDNS is only for discovery and points to the HTTP server anyway
As it is linked by zeroconfig. It should list all components as well
This is needed as mDNS found IP for services on local hosts isn't 127.0.0.1
to avoid confusion between flowchem devices and raw devices.
Flowchem device discovery over mDNS async version to be used inline in code, sync to be refactored as standalone click command for debug
To be used as client for flowchem devices
only relevant for import sorting
Also use AnyHttpUrl instead of custom URL
device info and component info respectively
check if it works in ga
is still respected but there's a circular dependency from flowchem_test and the new changeset in flowchem... Pointless to check now that is implemented in FlowchemDevice
* Use standard NameEmail instead of custom Person To enable list of str parsing for authors (e.g. in manifest files). Optional bonus is email validation. * Improve docstrings in configuration_parser.py * Add Flowchem base classe To hold the event loop and link to device registry, entities registry and event bus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.