Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USER statement with numeric value breaks syntax highlighting #30

Closed
gruhn opened this issue Jan 11, 2023 · 6 comments
Closed

USER statement with numeric value breaks syntax highlighting #30

gruhn opened this issue Jan 11, 2023 · 6 comments

Comments

@gruhn
Copy link

gruhn commented Jan 11, 2023

Screenshot 2023-01-11 at 19 10 58

For copy/paste:

FROM ubuntu

USER root
WORKDIR /home

USER 1000
WORKDIR /home
@camdencheek
Copy link
Owner

camdencheek commented Jan 18, 2023

Thanks for the report! I'm hoping to do some triage this weekend.

@gruhn
Copy link
Author

gruhn commented Mar 2, 2023

Actually, can't reproduce anymore. Maybe I was on an older version. Sorry, for the noise. Issue can be closed from my side.

@LeoniePhiline
Copy link

LeoniePhiline commented Apr 18, 2023

I can still reproduce the issue.

See helix-editor/helix#6797

edit: hm, should be fixed with 71ac1e8
Maybe Helix needs to update to a newer ref.

Helix uses 7af32bc - that’s really old.

@Quitlox
Copy link
Contributor

Quitlox commented May 1, 2023

I have found a related issue, albeit in a very specific scenario. It seems that the format USER <capital letters><dash><any> breaks the formatting:

image

image

Should I make a separate issue?

@LeoniePhiline
Copy link

LeoniePhiline commented May 1, 2023

The regex at

choice(/([a-z][-a-z0-9_]*|[0-9]+)/, $.expansion),
excludes capital letters.

Edit: Yes, that would be a different issue.

@camdencheek
Copy link
Owner

camdencheek commented Apr 19, 2024

Closing since I can no longer reproduce on the latest main and it looks like this was a case of "downstream hadn't updated for a while"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants